Commit e74783ec authored Sep 24, 2008 by Sven Wegener Committed by Jean Delvare Sep 24, 2008

i2c-dev: Return correct error code on class_create() failure



We need to convert the error pointer from class_create(), else we'll return the
successful return code from register_chrdev() on failure.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

parent 4ebb52d3

drivers/i2c/i2c-dev.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -583,8 +583,10 @@ static int __init i2c_dev_init(void)
		goto out;

		i2c_dev_class = class_create(THIS_MODULE, "i2c-dev");
		if (IS_ERR(i2c_dev_class))
		if (IS_ERR(i2c_dev_class)) {
		res = PTR_ERR(i2c_dev_class);
		goto out_unreg_chrdev;
		}

		res = i2c_add_driver(&i2cdev_driver);
		if (res)

Admin message