Commit e730c823 authored Oct 11, 2011 by Jiri Pirko Committed by David S. Miller Oct 18, 2011

tg3: negate USE_PHYLIB flag check



USE_PHYLIB flag in tg3_remove_one() is being checked incorrectly. This
results tg3_phy_fini->phy_disconnect is never called and when tg3 module
is removed.

In my case this resulted in panics in phy_state_machine calling function
phydev->adjust_link.

So correct this check.

Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Acked-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d5123480

drivers/net/tg3.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -15577,7 +15577,7 @@ static void __devexit tg3_remove_one(struct pci_dev *pdev)

		cancel_work_sync(&tp->reset_task);

		if (!tg3_flag(tp, USE_PHYLIB)) {
		if (tg3_flag(tp, USE_PHYLIB)) {
		tg3_phy_fini(tp);
		tg3_mdio_fini(tp);
		}

Admin message