Commit e72bde6b authored Oct 24, 2018 by David Ahern Committed by David S. Miller Oct 24, 2018

net: sched: Remove TCA_OPTIONS from policy



Marco reported an error with hfsc:
root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
Error: Attribute failed policy validation.

Apparently a few implementations pass TCA_OPTIONS as a binary instead
of nested attribute, so drop TCA_OPTIONS from the policy.

Fixes: 8b4c3cdd ("net: sched: Add policy validation for tc attributes")
Reported-by: Marco Berizzi <pupilla@libero.it>
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ac0e5496

net/sched/sch_api.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1320,7 +1320,6 @@ check_loop_fn(struct Qdisc q, unsigned long cl, struct qdisc_walker w)

		const struct nla_policy rtm_tca_policy[TCA_MAX + 1] = {
		[TCA_KIND] = { .type = NLA_STRING },
		[TCA_OPTIONS] = { .type = NLA_NESTED },
		[TCA_RATE] = { .type = NLA_BINARY,
		.len = sizeof(struct tc_estimator) },
		[TCA_STAB] = { .type = NLA_NESTED },

Admin message