Commit e72685db authored Jan 25, 2018 by Jia-Ju Bai Committed by Tejun Heo Jan 25, 2018

ata: sata_mv: Replace mdelay with usleep_range in mv_reset_channel



After checking all possible call chains to mv_reset_channel here,
my tool finds that mv_reset_channel is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
Thus mdelay can be replaced with usleep_range to avoid busy wait.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 65904252

drivers/ata/sata_mv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3596,7 +3596,7 @@ static void mv_reset_channel(struct mv_host_priv hpriv, void __iomem mmio,
		hpriv->ops->phy_errata(hpriv, mmio, port_no);

		if (IS_GEN_I(hpriv))
		mdelay(1);
		usleep_range(500, 1000);
		}

		static void mv_pmp_select(struct ata_port *ap, int pmp)

Admin message