Commit e70b9522 authored by Marc Zyngier's avatar Marc Zyngier Committed by Christoffer Dall
Browse files

arm64: KVM: Treat sysreg accessors returning false as successful 



Instead of considering that a sysreg accessor has failed when
returning false, let's consider that it is *always* successful
(after all, we won't stand for an incomplete emulation).

The return value now simply indicates whether we should skip
the instruction (because it has now been emulated), or if we
should leave the PC alone if the emulation has injected an
exception.

Reviewed-by: default avatarChristoffer Dall <cdall@linaro.org>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent e0443230

arch/arm64/kvm/sys_regs.c

+20 −29
Original line number Original line Diff line number Diff line
@@ -1571,6 +1571,22 @@ int kvm_handle_cp14_load_store(struct kvm_vcpu *vcpu, struct kvm_run *run) 
	return 1;

	return 1;

}

}





static void perform_access(struct kvm_vcpu *vcpu,

			   struct sys_reg_params *params,

			   const struct sys_reg_desc *r)

{

	/*

	 * Not having an accessor means that we have configured a trap

	 * that we don't know how to handle. This certainly qualifies

	 * as a gross bug that should be fixed right away.

	 */

	BUG_ON(!r->access);



	/* Skip instruction if instructed so */

	if (likely(r->access(vcpu, params, r)))

		kvm_skip_instr(vcpu, kvm_vcpu_trap_il_is32bit(vcpu));

}



/*

/*

 * emulate_cp --  tries to match a sys_reg access in a handling table, and

 * emulate_cp --  tries to match a sys_reg access in a handling table, and

 *                call the corresponding trap handler.

 *                call the corresponding trap handler.
@@ -1594,21 +1610,9 @@ static int emulate_cp(struct kvm_vcpu *vcpu, 
	r = find_reg(params, table, num);

	r = find_reg(params, table, num);





	if (r) {

	if (r) {

		/*

		perform_access(vcpu, params, r);

		 * Not having an accessor means that we have

		 * configured a trap that we don't know how to

		 * handle. This certainly qualifies as a gross bug

		 * that should be fixed right away.

		 */

		BUG_ON(!r->access);



		if (likely(r->access(vcpu, params, r))) {

			/* Skip instruction, since it was emulated */

			kvm_skip_instr(vcpu, kvm_vcpu_trap_il_is32bit(vcpu));

			/* Handled */

		return 0;

		return 0;

	}

	}

	}





	/* Not handled */

	/* Not handled */

	return -1;

	return -1;
@@ -1777,26 +1781,13 @@ static int emulate_sys_reg(struct kvm_vcpu *vcpu, 
		r = find_reg(params, sys_reg_descs, ARRAY_SIZE(sys_reg_descs));

		r = find_reg(params, sys_reg_descs, ARRAY_SIZE(sys_reg_descs));





	if (likely(r)) {

	if (likely(r)) {

		/*

		perform_access(vcpu, params, r);

		 * Not having an accessor means that we have

		 * configured a trap that we don't know how to

		 * handle. This certainly qualifies as a gross bug

		 * that should be fixed right away.

		 */

		BUG_ON(!r->access);



		if (likely(r->access(vcpu, params, r))) {

			/* Skip instruction, since it was emulated */

			kvm_skip_instr(vcpu, kvm_vcpu_trap_il_is32bit(vcpu));

			return 1;

		}

		/* If access function fails, it should complain. */

	} else {

	} else {

		kvm_err("Unsupported guest sys_reg access at: %lx\n",

		kvm_err("Unsupported guest sys_reg access at: %lx\n",

			*vcpu_pc(vcpu));

			*vcpu_pc(vcpu));

		print_sys_reg_instr(params);

		print_sys_reg_instr(params);

	}

		kvm_inject_undefined(vcpu);

		kvm_inject_undefined(vcpu);

	}

	return 1;

	return 1;

}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE