Commit e70ac628 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

qed: remove redundant assignments to rc 



The variable rc is assigned with a value that is never read and
it is re-assigned a new value later on.  The assignment is redundant
and can be removed.  Clean up multiple occurrances of this pattern.

Addresses-Coverity: ("Unused value")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 718eae27

drivers/net/ethernet/qlogic/qed/qed_sp_commands.c

+5 −5
Original line number Diff line number Diff line
@@ -331,8 +331,8 @@ int qed_sp_pf_start(struct qed_hwfn *p_hwfn, 
	u8 sb_index = p_hwfn->p_eq->eq_sb_index;

	struct qed_spq_entry *p_ent = NULL;

	struct qed_sp_init_data init_data;

	int rc = -EINVAL;

	u8 page_cnt, i;

	int rc;



	/* update initial eq producer */

	qed_eq_prod_update(p_hwfn,
@@ -447,7 +447,7 @@ int qed_sp_pf_update(struct qed_hwfn *p_hwfn) 
{

	struct qed_spq_entry *p_ent = NULL;

	struct qed_sp_init_data init_data;

	int rc = -EINVAL;

	int rc;



	/* Get SPQ entry */

	memset(&init_data, 0, sizeof(init_data));
@@ -471,7 +471,7 @@ int qed_sp_pf_update_ufp(struct qed_hwfn *p_hwfn) 
{

	struct qed_spq_entry *p_ent = NULL;

	struct qed_sp_init_data init_data;

	int rc = -EOPNOTSUPP;

	int rc;



	if (p_hwfn->ufp_info.pri_type == QED_UFP_PRI_UNKNOWN) {

		DP_INFO(p_hwfn, "Invalid priority type %d\n",
@@ -509,7 +509,7 @@ int qed_sp_pf_update_tunn_cfg(struct qed_hwfn *p_hwfn, 
{

	struct qed_spq_entry *p_ent = NULL;

	struct qed_sp_init_data init_data;

	int rc = -EINVAL;

	int rc;



	if (IS_VF(p_hwfn->cdev))

		return qed_vf_pf_tunnel_param_update(p_hwfn, p_tunn);
@@ -546,7 +546,7 @@ int qed_sp_pf_stop(struct qed_hwfn *p_hwfn) 
{

	struct qed_spq_entry *p_ent = NULL;

	struct qed_sp_init_data init_data;

	int rc = -EINVAL;

	int rc;



	/* Get SPQ entry */

	memset(&init_data, 0, sizeof(init_data));

CRA Git | Maintained and supported by SUSTech CRA and CCSE