Commit e6f791d9 authored Jan 25, 2018 by Dan Carpenter Committed by Martin K. Petersen Jan 30, 2018

scsi: sym53c8xx_2: iterator underflow in sym_getsync()



We wanted to exit the loop with "div" set to zero, but instead, if we
don't hit the break then "div" is -1 when we finish the loop.  It leads
to an array underflow a few lines later.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Matthew Wilcox <mawilcox@microsoft.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ecf7ff49

drivers/scsi/sym53c8xx_2/sym_hipd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -536,7 +536,7 @@ sym_getsync(struct sym_hcb np, u_char dt, u_char sfac, u_char divp, u_char *fa
		* Look for the greatest clock divisor that allows an
		* input speed faster than the period.
		*/
		while (div-- > 0)
		while (--div > 0)
		if (kpc >= (div_10M[div] << 2)) break;

		/*

Admin message