regulator: qcom: labibb: Constify static structs (e6f5ff17) · Commits · 戴 / test

The only usage of qcom_labibb_ops is to assign it to the ops field in the regulator_desc struct, which is a const pointer. The only usage of pmi8998_lab_desc and pmi8998_ibb_desc is to assign their address to the desc field in the labibb_regulator_data struct which can be made const, since it is only copied into the desc field in the labbibb_regulator_data struct. This struct is modified, but that's a copy of the static one. Make them const to allow the compiler to put them in read-only memory. Signed-off-by:

Rikard Falkeborn <rikard.falkeborn@gmail.com> Link: https://lore.kernel.org/r/20200930162602.18583-1-rikard.falkeborn@gmail.com Signed-off-by:

Mark Brown <broonie@kernel.org>

drivers/regulator/qcom-labibb-regulator.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -44,16 +44,16 @@ struct labibb_regulator_data {
		const char *name;
		u8 type;
		u16 base;
		struct regulator_desc *desc;
		const struct regulator_desc *desc;
		};

		static struct regulator_ops qcom_labibb_ops = {
		static const struct regulator_ops qcom_labibb_ops = {
		.enable = regulator_enable_regmap,
		.disable = regulator_disable_regmap,
		.is_enabled = regulator_is_enabled_regmap,
		};

		static struct regulator_desc pmi8998_lab_desc = {
		static const struct regulator_desc pmi8998_lab_desc = {
		.enable_mask = LAB_ENABLE_CTL_MASK,
		.enable_reg = (PMI8998_LAB_REG_BASE + REG_LABIBB_ENABLE_CTL),
		.enable_val = LABIBB_CONTROL_ENABLE,
		@@ -65,7 +65,7 @@ static struct regulator_desc pmi8998_lab_desc = {
		.ops = &qcom_labibb_ops,
		};

		static struct regulator_desc pmi8998_ibb_desc = {
		static const struct regulator_desc pmi8998_ibb_desc = {
		.enable_mask = IBB_ENABLE_CTL_MASK,
		.enable_reg = (PMI8998_IBB_REG_BASE + REG_LABIBB_ENABLE_CTL),
		.enable_val = LABIBB_CONTROL_ENABLE,

Admin message