Commit e6f390a8 authored Jun 04, 2020 by Navid Emamdoost Committed by Linus Walleij Jun 16, 2020

gpio: arizona: handle pm_runtime_get_sync failure case



Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count. Call pm_runtime_put if
pm_runtime_get_sync fails.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20200605025207.65719-1-navid.emamdoost@gmail.com


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent b3a9e3b9

drivers/gpio/gpio-arizona.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -106,6 +106,7 @@ static int arizona_gpio_direction_out(struct gpio_chip *chip,
		ret = pm_runtime_get_sync(chip->parent);
		if (ret < 0) {
		dev_err(chip->parent, "Failed to resume: %d\n", ret);
		pm_runtime_put(chip->parent);
		return ret;
		}
		}

Admin message