Commit e6eb2eba authored Jan 15, 2015 by Laurent Dufour Committed by Michael Ellerman Jan 19, 2015

powerpc/xmon: Fix another endiannes issue in RTAS call from xmon



The commit 3b8a3c01 ("powerpc/pseries: Fix endiannes issue in RTAS
call from xmon") was fixing an endianness issue in the call made from
xmon to RTAS.

However, as Michael Ellerman noticed, this fix was not complete, the
token value was not byte swapped. This lead to call an unexpected and
most of the time unexisting RTAS function, which is silently ignored by
RTAS.

This fix addresses this hole.

Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Cc: stable@vger.kernel.org
Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent ec6f34e5

arch/powerpc/xmon/xmon.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -337,6 +337,7 @@ static inline void disable_surveillance(void)
	args.token = rtas_token("set-indicator");		args.token = rtas_token("set-indicator");
	if (args.token == RTAS_UNKNOWN_SERVICE)		if (args.token == RTAS_UNKNOWN_SERVICE)
	return;		return;
			args.token = cpu_to_be32(args.token);
	args.nargs = cpu_to_be32(3);		args.nargs = cpu_to_be32(3);
	args.nret = cpu_to_be32(1);		args.nret = cpu_to_be32(1);
	args.rets = &args.args[3];		args.rets = &args.args[3];

Admin message