Commit e6d0fb7b authored Apr 10, 2019 by Ronnie Sahlberg Committed by Steve French Apr 16, 2019

cifs: fix handle leak in smb2_query_symlink()



If we enter smb2_query_symlink() for something that is not a symlink
and where the SMB2_open() would succeed we would never end up
closing this handle and would thus leak a handle on the server.

Fix this by immediately calling SMB2_close() on successfull open.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>

parent b57a55e2

fs/cifs/smb2ops.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2389,6 +2389,8 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon,

		rc = SMB2_open(xid, &oparms, utf16_path, &oplock, NULL, &err_iov,
		&resp_buftype);
		if (!rc)
		SMB2_close(xid, tcon, fid.persistent_fid, fid.volatile_fid);
		if (!rc \|\| !err_iov.iov_base) {
		rc = -ENOENT;
		goto free_path;

Admin message