Commit e6c45149 authored Jul 25, 2019 by Tony Nguyen Committed by Jeff Kirsher Aug 20, 2019

ice: Do not always bring up PF VSI in ice_ena_vsi()



During rebuild ice_ena_vsi() is called to recover the VSI state.
This function assumes the PF VSI is always to be enabled, however,
it's possible that during reset/rebuild the interface can be
brought down.  If this occurs, we can attempt to bring up the PF
VSI on a downed interface which can lead to various crashes. If
the interface is not running, do not bring up the associated VSI.

Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent ac6f733a

drivers/net/ethernet/intel/ice/ice_main.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -3701,8 +3701,6 @@ static int ice_ena_vsi(struct ice_vsi *vsi, bool locked)
		err = netd->netdev_ops->ndo_open(netd);
		rtnl_unlock();
		}
		} else {
		err = ice_vsi_open(vsi);
		}
		}

Admin message