ata: Disabling the async PM for JMicron chip 363/361 (e6b7e41c) · Commits · 戴 / test

After enabled the PM feature that supporting async noirq( (PM / sleep: Asynchronous threads for resume_noirq)), Jay hit the system resuming issue, that one of the JMicron controller can not be powered up. His device tree is like below: +-1c.4-[02]--+-00.0 JMicron Technology Corp. JMB363 SATA/IDE Controller | \-00.1 JMicron Technology Corp. JMB363 SATA/IDE Controller After investigation, we found the the Micron chip 363 included one SATA controller(0000:02:00.0) and one PATA controller(0000:02:00.1), these two controllers do not have parent-children relationship, but the PATA controller only can be powered on after the SATA controller has finished the powering on. If we enabled the async noirq(), then the below error is hit during noirq phase: pata_jmicron 0000:02:00.1: Refused to change power state, currently in D3 Here for JMicron chip 363/361, we need forcedly to disable the async method. Bug detail: https://bugzilla.kernel.org/show_bug.cgi?id=81551 Reported-by:

Jay <MyMailClone@t-online.de> Signed-off-by:

Chuansheng Liu <chuansheng.liu@intel.com> Acked-by:

Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by:

Tejun Heo <tj@kernel.org>

drivers/ata/ahci.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -1337,6 +1337,18 @@ static int ahci_init_one(struct pci_dev pdev, const struct pci_device_id ent)
		else if (pdev->vendor == 0x1c44 && pdev->device == 0x8000)
		ahci_pci_bar = AHCI_PCI_BAR_ENMOTUS;

		/*
		* The JMicron chip 361/363 contains one SATA controller and one
		* PATA controller,for powering on these both controllers, we must
		* follow the sequence one by one, otherwise one of them can not be
		* powered on successfully, so here we disable the async suspend
		* method for these chips.
		*/
		if (pdev->vendor == PCI_VENDOR_ID_JMICRON &&
		(pdev->device == PCI_DEVICE_ID_JMICRON_JMB363 \|\|
		pdev->device == PCI_DEVICE_ID_JMICRON_JMB361))
		device_disable_async_suspend(&pdev->dev);

		/* acquire resources */
		rc = pcim_enable_device(pdev);
		if (rc)

drivers/ata/pata_jmicron.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -143,6 +143,18 @@ static int jmicron_init_one (struct pci_dev pdev, const struct pci_device_id i
		};
		const struct ata_port_info *ppi[] = { &info, NULL };

		/*
		* The JMicron chip 361/363 contains one SATA controller and one
		* PATA controller,for powering on these both controllers, we must
		* follow the sequence one by one, otherwise one of them can not be
		* powered on successfully, so here we disable the async suspend
		* method for these chips.
		*/
		if (pdev->vendor == PCI_VENDOR_ID_JMICRON &&
		(pdev->device == PCI_DEVICE_ID_JMICRON_JMB363 \|\|
		pdev->device == PCI_DEVICE_ID_JMICRON_JMB361))
		device_disable_async_suspend(&pdev->dev);

		return ata_pci_bmdma_init_one(pdev, ppi, &jmicron_sht, NULL, 0);
		}

Admin message