Commit e6a47428 authored Nov 15, 2009 by Theodore Ts'o

jbd2: don't wipe the journal on a failed journal checksum



If there is a failed journal checksum, don't reset the journal.  This
allows for userspace programs to decide how to recover from this
situation.  It may be that ignoring the journal checksum failure might
be a better way of recovering the file system.  Once we add per-block
checksums, we can definitely do better.  Until then, a system
administrator can try backing up the file system image (or taking a
snapshot) and and trying to determine experimentally whether ignoring
the checksum failure or aborting the journal replay results in less
data loss.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org

parent 567f3e9a

fs/jbd2/journal.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1248,6 +1248,13 @@ int jbd2_journal_load(journal_t *journal)
		if (jbd2_journal_recover(journal))
		goto recovery_error;

		if (journal->j_failed_commit) {
		printk(KERN_ERR "JBD2: journal transaction %u on %s "
		"is corrupt.\n", journal->j_failed_commit,
		journal->j_devname);
		return -EIO;
		}

		/* OK, we've finished with the dynamic journal bits:
		* reinitialise the dynamic contents of the superblock in memory
		* and reset them on disk. */

Admin message