Commit e68088e7 authored Feb 23, 2018 by Bart Van Assche Committed by Jason Gunthorpe Feb 28, 2018

IB/srp: Fix srp_abort()



Before commit e494f6a7 ("[SCSI] improved eh timeout handler") it
did not really matter whether or not abort handlers like srp_abort()
called .scsi_done() when returning another value than SUCCESS. Since
that commit however this matters. Hence only call .scsi_done() when
returning SUCCESS.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent a8ed7487

drivers/infiniband/ulp/srp/ib_srp.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -2974,9 +2974,11 @@ static int srp_abort(struct scsi_cmnd *scmnd)
		ret = FAST_IO_FAIL;
		else
		ret = FAILED;
		if (ret == SUCCESS) {
		srp_free_req(ch, req, scmnd, 0);
		scmnd->result = DID_ABORT << 16;
		scmnd->scsi_done(scmnd);
		}

		return ret;
		}

Admin message