Commit e67c718b authored by David Sterba's avatar David Sterba
Browse files

btrfs: add more __cold annotations 



The __cold functions are placed to a special section, as they're
expected to be called rarely. This could help i-cache prefetches or help
compiler to decide which branches are more/less likely to be taken
without any other annotations needed.

Though we can't add more __exit annotations, it's still possible to add
__cold (that's also added with __exit). That way the following function
categories are tagged:

- printf wrappers, error messages
- exit helpers

Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent ffc5a379

fs/btrfs/backref.c

+1 −1
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ int __init btrfs_prelim_ref_init(void) 
	return 0;

}



void btrfs_prelim_ref_exit(void)

void __cold btrfs_prelim_ref_exit(void)

{

	kmem_cache_destroy(btrfs_prelim_ref_cache);

}

fs/btrfs/backref.h

+1 −1
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ int btrfs_find_one_extref(struct btrfs_root *root, u64 inode_objectid, 
int btrfs_check_shared(struct btrfs_root *root, u64 inum, u64 bytenr);



int __init btrfs_prelim_ref_init(void);

void btrfs_prelim_ref_exit(void);

void __cold btrfs_prelim_ref_exit(void);



struct prelim_ref {

	struct rb_node rbnode;

fs/btrfs/compression.c

+1 −1
Original line number Diff line number Diff line
@@ -1133,7 +1133,7 @@ int btrfs_decompress(int type, unsigned char *data_in, struct page *dest_page, 
	return ret;

}



void btrfs_exit_compress(void)

void __cold btrfs_exit_compress(void)

{

	free_workspaces();

}

fs/btrfs/compression.h

+1 −1
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ struct compressed_bio { 
};



void __init btrfs_init_compress(void);

void btrfs_exit_compress(void);

void __cold btrfs_exit_compress(void);



int btrfs_compress_pages(unsigned int type_level, struct address_space *mapping,

			 u64 start, struct page **pages,

fs/btrfs/ctree.h

+5 −4
Original line number Diff line number Diff line
@@ -3204,7 +3204,7 @@ struct inode *btrfs_alloc_inode(struct super_block *sb); 
void btrfs_destroy_inode(struct inode *inode);

int btrfs_drop_inode(struct inode *inode);

int __init btrfs_init_cachep(void);

void btrfs_destroy_cachep(void);

void __cold btrfs_destroy_cachep(void);

long btrfs_ioctl_trans_end(struct file *file);

struct inode *btrfs_iget(struct super_block *s, struct btrfs_key *location,

			 struct btrfs_root *root, int *was_new);
@@ -3255,7 +3255,7 @@ ssize_t btrfs_dedupe_file_range(struct file *src_file, u64 loff, u64 olen, 


/* file.c */

int __init btrfs_auto_defrag_init(void);

void btrfs_auto_defrag_exit(void);

void __cold btrfs_auto_defrag_exit(void);

int btrfs_add_inode_defrag(struct btrfs_trans_handle *trans,

			   struct btrfs_inode *inode);

int btrfs_run_defrag_inodes(struct btrfs_fs_info *fs_info);
@@ -3290,7 +3290,7 @@ int btrfs_defrag_leaves(struct btrfs_trans_handle *trans, 


/* sysfs.c */

int __init btrfs_init_sysfs(void);

void btrfs_exit_sysfs(void);

void __cold btrfs_exit_sysfs(void);

int btrfs_sysfs_add_mounted(struct btrfs_fs_info *fs_info);

void btrfs_sysfs_remove_mounted(struct btrfs_fs_info *fs_info);
@@ -3302,13 +3302,14 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options, 
			unsigned long new_flags);

int btrfs_sync_fs(struct super_block *sb, int wait);



static inline __printf(2, 3)

static inline __printf(2, 3) __cold

void btrfs_no_printk(const struct btrfs_fs_info *fs_info, const char *fmt, ...)

{

}



#ifdef CONFIG_PRINTK

__printf(2, 3)

__cold

void btrfs_printk(const struct btrfs_fs_info *fs_info, const char *fmt, ...);

#else

#define btrfs_printk(fs_info, fmt, args...) \

CRA Git | Maintained and supported by SUSTech CRA and CCSE