uio: pruss: add clk_disable() (e663c5db) · Commits · 戴 / test

pruss_probe() enables gdev->pruss_clk, but there is no clk_disable() in the driver. The patch adds clk_disable() to pruss_cleanup() and error handling for clk_enable(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:

Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/uio/uio_pruss.c

+9 −1

Original line number	Original line	Diff line number	Diff line
	@@ -111,6 +111,7 @@ static void pruss_cleanup(struct device dev, struct uio_pruss_dev gdev)
	gdev->sram_vaddr,		gdev->sram_vaddr,
	sram_pool_sz);		sram_pool_sz);
	kfree(gdev->info);		kfree(gdev->info);
			clk_disable(gdev->pruss_clk);
	clk_put(gdev->pruss_clk);		clk_put(gdev->pruss_clk);
	kfree(gdev);		kfree(gdev);
	}		}
	@@ -143,7 +144,14 @@ static int pruss_probe(struct platform_device *pdev)
	kfree(gdev);		kfree(gdev);
	return ret;		return ret;
	} else {		} else {
	clk_enable(gdev->pruss_clk);		ret = clk_enable(gdev->pruss_clk);
			if (ret) {
			dev_err(dev, "Failed to enable clock\n");
			clk_put(gdev->pruss_clk);
			kfree(gdev->info);
			kfree(gdev);
			return ret;
			}
	}		}

	regs_prussio = platform_get_resource(pdev, IORESOURCE_MEM, 0);		regs_prussio = platform_get_resource(pdev, IORESOURCE_MEM, 0);

Admin message