Commit e647e291 authored Dec 04, 2018 by ruippan (潘睿) Committed by Theodore Ts'o Dec 04, 2018

ext4: fix EXT4_IOC_GROUP_ADD ioctl



Commit e2b911c5 ("ext4: clean up feature test macros with
predicate functions") broke the EXT4_IOC_GROUP_ADD ioctl.  This was
not noticed since only very old versions of resize2fs (before
e2fsprogs 1.42) use this ioctl.  However, using a new kernel with an
enterprise Linux userspace will cause attempts to use online resize to
fail with "No reserved GDT blocks".

Fixes: e2b911c5 ("ext4: clean up feature test macros with predicate...")
Cc: stable@kernel.org # v4.4
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: ruippan (潘睿) <ruippan@tencent.com>

parent 361d24d4

fs/ext4/resize.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1631,7 +1631,7 @@ int ext4_group_add(struct super_block sb, struct ext4_new_group_data input)
		}

		if (reserved_gdb \|\| gdb_off == 0) {
		if (ext4_has_feature_resize_inode(sb) \|\|
		if (!ext4_has_feature_resize_inode(sb) \|\|
		!le16_to_cpu(es->s_reserved_gdt_blocks)) {
		ext4_warning(sb,
		"No reserved GDT blocks, can't resize");

Admin message