Commit e6441bae authored Mar 09, 2015 by Jon Paul Maloy Committed by David S. Miller Mar 09, 2015

tipc: fix bug in link failover handling



In commit c637c103
("tipc: resolve race problem at unicast message reception") we
introduced a new mechanism for delivering buffers upwards from link
to socket layer.

That code contains a bug in how we handle the new link input queue
during failover. When a link is reset, some of its users may be blocked
because of congestion, and in order to resolve this, we add any pending
wakeup pseudo messages to the link's input queue, and deliver them to
the socket. This misses the case where the other, remaining link also
may have congested users. Currently, the owner node's reference to the
remaining link's input queue is unconditionally overwritten by the
reset link's input queue. This has the effect that wakeup events from
the remaining link may be unduely delayed (but not lost) for a
potentially long period.

We fix this by adding the pending events from the reset link to the
input queue that is currently referenced by the node, whichever one
it is.

This commit should be applied to both net and net-next.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 82f17091

net/tipc/link.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -464,10 +464,11 @@ void tipc_link_reset(struct tipc_link *l_ptr)
		/* Clean up all queues, except inputq: */
		__skb_queue_purge(&l_ptr->outqueue);
		__skb_queue_purge(&l_ptr->deferred_queue);
		skb_queue_splice_init(&l_ptr->wakeupq, &l_ptr->inputq);
		if (!skb_queue_empty(&l_ptr->inputq))
		owner->action_flags \|= TIPC_MSG_EVT;
		if (!owner->inputq)
		owner->inputq = &l_ptr->inputq;
		skb_queue_splice_init(&l_ptr->wakeupq, owner->inputq);
		if (!skb_queue_empty(owner->inputq))
		owner->action_flags \|= TIPC_MSG_EVT;
		l_ptr->next_out = NULL;
		l_ptr->unacked_window = 0;
		l_ptr->checkpoint = 1;

Admin message