Commit e6417577 authored Jan 13, 2020 by Krzysztof Kozlowski Committed by Wolfram Sang Jan 15, 2020

i2c: iop3xx: Fix memory leak in probe error path

When handling devm_gpiod_get_optional() errors, free the memory already
allocated. This fixes Smatch warnings:

drivers/i2c/busses/i2c-iop3xx.c:437 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'
drivers/i2c/busses/i2c-iop3xx.c:442 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'

Fixes: fdb7e884 ("i2c: iop: Use GPIO descriptors")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent 24a49678

drivers/i2c/busses/i2c-iop3xx.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -433,13 +433,17 @@ iop3xx_i2c_probe(struct platform_device *pdev)
		adapter_data->gpio_scl = devm_gpiod_get_optional(&pdev->dev,
		"scl",
		GPIOD_ASIS);
		if (IS_ERR(adapter_data->gpio_scl))
		return PTR_ERR(adapter_data->gpio_scl);
		if (IS_ERR(adapter_data->gpio_scl)) {
		ret = PTR_ERR(adapter_data->gpio_scl);
		goto free_both;
		}
		adapter_data->gpio_sda = devm_gpiod_get_optional(&pdev->dev,
		"sda",
		GPIOD_ASIS);
		if (IS_ERR(adapter_data->gpio_sda))
		return PTR_ERR(adapter_data->gpio_sda);
		if (IS_ERR(adapter_data->gpio_sda)) {
		ret = PTR_ERR(adapter_data->gpio_sda);
		goto free_both;
		}

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (!res) {

Admin message