Commit e62780e6 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

net: ll_temac: let core reject the unsupported coalescing parameters 



Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver already correctly rejected all unsupported
parameters. No functional changes.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1a9d729c

drivers/net/ethernet/xilinx/ll_temac_main.c

+2 −19
Original line number Diff line number Diff line
@@ -1314,25 +1314,6 @@ static int ll_temac_ethtools_set_coalesce(struct net_device *ndev, 
		return -EFAULT;

	}



	if (ec->rx_coalesce_usecs_irq ||

	    ec->rx_max_coalesced_frames_irq ||

	    ec->tx_coalesce_usecs_irq ||

	    ec->tx_max_coalesced_frames_irq ||

	    ec->stats_block_coalesce_usecs ||

	    ec->use_adaptive_rx_coalesce ||

	    ec->use_adaptive_tx_coalesce ||

	    ec->pkt_rate_low ||

	    ec->rx_coalesce_usecs_low ||

	    ec->rx_max_coalesced_frames_low ||

	    ec->tx_coalesce_usecs_low ||

	    ec->tx_max_coalesced_frames_low ||

	    ec->pkt_rate_high ||

	    ec->rx_coalesce_usecs_high ||

	    ec->rx_max_coalesced_frames_high ||

	    ec->tx_coalesce_usecs_high ||

	    ec->tx_max_coalesced_frames_high ||

	    ec->rate_sample_interval)

		return -EOPNOTSUPP;

	if (ec->rx_max_coalesced_frames)

		lp->coalesce_count_rx = ec->rx_max_coalesced_frames;

	if (ec->tx_max_coalesced_frames)
@@ -1351,6 +1332,8 @@ static int ll_temac_ethtools_set_coalesce(struct net_device *ndev, 
}



static const struct ethtool_ops temac_ethtool_ops = {

	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |

				     ETHTOOL_COALESCE_MAX_FRAMES,

	.nway_reset = phy_ethtool_nway_reset,

	.get_link = ethtool_op_get_link,

	.get_ts_info = ethtool_op_get_ts_info,

CRA Git | Maintained and supported by SUSTech CRA and CCSE