Commit e61a2356 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Herbert Xu
Browse files

crypto: sun8i - Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Acked-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 5a062f09

drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c

+3 −6
Original line number Diff line number Diff line
@@ -573,12 +573,9 @@ static int sun8i_ce_probe(struct platform_device *pdev) 
		return irq;



	ce->reset = devm_reset_control_get(&pdev->dev, NULL);

	if (IS_ERR(ce->reset)) {

		if (PTR_ERR(ce->reset) == -EPROBE_DEFER)

			return PTR_ERR(ce->reset);

		dev_err(&pdev->dev, "No reset control found\n");

		return PTR_ERR(ce->reset);

	}

	if (IS_ERR(ce->reset))

		return dev_err_probe(&pdev->dev, PTR_ERR(ce->reset),

				     "No reset control found\n");



	mutex_init(&ce->mlock);

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c

+3 −6
Original line number Diff line number Diff line
@@ -545,12 +545,9 @@ static int sun8i_ss_probe(struct platform_device *pdev) 
		return irq;



	ss->reset = devm_reset_control_get(&pdev->dev, NULL);

	if (IS_ERR(ss->reset)) {

		if (PTR_ERR(ss->reset) == -EPROBE_DEFER)

			return PTR_ERR(ss->reset);

		dev_err(&pdev->dev, "No reset control found\n");

		return PTR_ERR(ss->reset);

	}

	if (IS_ERR(ss->reset))

		return dev_err_probe(&pdev->dev, PTR_ERR(ss->reset),

				     "No reset control found\n");



	mutex_init(&ss->mlock);

CRA Git | Maintained and supported by SUSTech CRA and CCSE