Commit e6158b4a authored Oct 12, 2005 by Lothar Wassmann Committed by Russell King Oct 12, 2005

[ARM] 3002/1: Wrong parameter to uart_update_timeout() in drivers/serial/pxa.c



Patch from Lothar Wassmann

The function serial_pxa_set_termios() is calling uart_update_timeout()
with the baud rate divisor as third parameter, while
uart_update_timeout() expects the baud rate in this place.
This results in a bogus port->timeout which is proportional to the
baud rate.

Signed-off-by: Lothar Wassmann <LW@KARO-electronics.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent 6ec5e7f3

drivers/serial/pxa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -499,7 +499,7 @@ serial_pxa_set_termios(struct uart_port port, struct termios termios,
		/*
		* Update the per-port timeout.
		*/
		uart_update_timeout(port, termios->c_cflag, quot);
		uart_update_timeout(port, termios->c_cflag, baud);

		up->port.read_status_mask = UART_LSR_OE \| UART_LSR_THRE \| UART_LSR_DR;
		if (termios->c_iflag & INPCK)

Admin message