Commit e613cc47 authored Jun 23, 2016 by Adrian Hunter Committed by Ulf Hansson Jul 25, 2016

mmc: sdhci: Fix sdhci_card_busy()



host->card_busy() was introduced for SD voltage switching which checks all
4 data lines.

Increasingly, host->card_busy is being used to poll the the busy signal
which is only data line 0 (DAT[0]).

The current logic in sdhci_card_busy() does not work in that case because
it returns false if any of the data lines is high.  It also ignores
possibilities:
	- data lines 1-3 are not connected and could show at any level
	- data lines 1-2 can be used by SDIO for other purposes

According to the SD specification, it is OK to check any of the data lines
for voltage switching, so change to use DAT[0] only.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 7c42dbf3

drivers/mmc/host/sdhci.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1811,10 +1811,10 @@ static int sdhci_card_busy(struct mmc_host *mmc)
		struct sdhci_host *host = mmc_priv(mmc);
		u32 present_state;

		/* Check whether DAT[3:0] is 0000 */
		/* Check whether DAT[0] is 0 */
		present_state = sdhci_readl(host, SDHCI_PRESENT_STATE);

		return !(present_state & SDHCI_DATA_LVL_MASK);
		return !(present_state & SDHCI_DATA_0_LVL_MASK);
		}

		static int sdhci_prepare_hs400_tuning(struct mmc_host mmc, struct mmc_ios ios)

Admin message