NFSv4: Update the attribute cache info in update_changeattr (e603a4c1) · Commits · 戴 / test

If we successfully updated the change attribute, we should timestamp the cache. While we do know that the other attributes are not completely up to date, we have the NFS_INO_INVALID_ATTR flag that let us know that, so it is valid to say that the cache has not timed out. We can also clear NFS_INO_REVAL_PAGECACHE, since our change attribute is now known to be valid. Conversely, if the change attribute did not match, we should make sure to also revalidate the access and ACL caches. Signed-off-by:

Trond Myklebust <trond.myklebust@primarydata.com>

fs/nfs/nfs4proc.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -1089,8 +1089,15 @@ static void update_changeattr(struct inode dir, struct nfs4_change_info cinfo)

		spin_lock(&dir->i_lock);
		nfsi->cache_validity \|= NFS_INO_INVALID_ATTR\|NFS_INO_INVALID_DATA;
		if (!cinfo->atomic \|\| cinfo->before != dir->i_version)
		if (cinfo->atomic && cinfo->before == dir->i_version) {
		nfsi->cache_validity &= ~NFS_INO_REVAL_PAGECACHE;
		nfsi->attrtimeo_timestamp = jiffies;
		} else {
		nfs_force_lookup_revalidate(dir);
		if (cinfo->before != dir->i_version)
		nfsi->cache_validity \|= NFS_INO_INVALID_ACCESS \|
		NFS_INO_INVALID_ACL;
		}
		dir->i_version = cinfo->after;
		nfsi->attr_gencount = nfs_inc_attr_generation_counter();
		nfs_fscache_invalidate(dir);

Admin message