Commit e5f0b521 authored Jan 13, 2020 by Nicholas Kazlauskas Committed by Alex Deucher Jan 22, 2020

drm/amd/display: Check hw_init state when determining if DMCUB is initialized



[Why]
CW2 may already be programmed when coming back from S4. In this case
we want to unconditionally replace whatever DMCUB version is currently
enabled with the latest.

[How]
Check the hw_init flag to know whether or not we've previously executed
the initliazed routine.

Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent a7da96fb

drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -312,6 +312,9 @@ enum dmub_status dmub_srv_is_hw_init(struct dmub_srv dmub, bool is_hw_init)
		if (!dmub->sw_init)
		return DMUB_STATUS_INVALID;

		if (!dmub->hw_init)
		return DMUB_STATUS_OK;

		if (dmub->hw_funcs.is_hw_init)
		*is_hw_init = dmub->hw_funcs.is_hw_init(dmub);

Admin message