Commit e5e97ee9 authored by Dan Williams's avatar Dan Williams Committed by David S. Miller
Browse files

hso: fix handling of modem port SERIAL_STATE notifications 



The existing serial state notification handling expected older Option
devices, having a hardcoded assumption that the Modem port was always
USB interface #2.  That isn't true for devices from the past few years.

hso_serial_state_notification is a local cache of a USB Communications
Interface Class SERIAL_STATE notification from the device, and the
USB CDC specification (section 6.3, table 67 "Class-Specific Notifications")
defines wIndex as the USB interface the event applies to.  For hso
devices this will always be the Modem port, as the Modem port is the
only port which is set up to receive them by the driver.

So instead of always expecting USB interface #2, instead validate the
notification with the actual USB interface number of the Modem port.

Signed-off-by: default avatarDan Williams <dcbw@redhat.com>
Tested-by: default avatarH. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 22d3b76e

drivers/net/usb/hso.c

+11 −2
Original line number Diff line number Diff line
@@ -185,7 +185,6 @@ enum rx_ctrl_state{ 
#define BM_REQUEST_TYPE (0xa1)

#define B_NOTIFICATION  (0x20)

#define W_VALUE         (0x0)

#define W_INDEX         (0x2)

#define W_LENGTH        (0x2)



#define B_OVERRUN       (0x1<<6)
@@ -1487,6 +1486,7 @@ static void tiocmget_intr_callback(struct urb *urb) 
	struct uart_icount *icount;

	struct hso_serial_state_notification *serial_state_notification;

	struct usb_device *usb;

	int if_num;



	/* Sanity checks */

	if (!serial)
@@ -1495,15 +1495,24 @@ static void tiocmget_intr_callback(struct urb *urb) 
		handle_usb_error(status, __func__, serial->parent);

		return;

	}



	/* tiocmget is only supported on HSO_PORT_MODEM */

	tiocmget = serial->tiocmget;

	if (!tiocmget)

		return;

	BUG_ON((serial->parent->port_spec & HSO_PORT_MASK) != HSO_PORT_MODEM);



	usb = serial->parent->usb;

	if_num = serial->parent->interface->altsetting->desc.bInterfaceNumber;



	/* wIndex should be the USB interface number of the port to which the

	 * notification applies, which should always be the Modem port.

	 */

	serial_state_notification = &tiocmget->serial_state_notification;

	if (serial_state_notification->bmRequestType != BM_REQUEST_TYPE ||

	    serial_state_notification->bNotification != B_NOTIFICATION ||

	    le16_to_cpu(serial_state_notification->wValue) != W_VALUE ||

	    le16_to_cpu(serial_state_notification->wIndex) != W_INDEX ||

	    le16_to_cpu(serial_state_notification->wIndex) != if_num ||

	    le16_to_cpu(serial_state_notification->wLength) != W_LENGTH) {

		dev_warn(&usb->dev,

			 "hso received invalid serial state notification\n");

CRA Git | Maintained and supported by SUSTech CRA and CCSE