Commit e5e7d805 authored Jun 24, 2020 by Jason A. Donenfeld Committed by David S. Miller Jun 25, 2020

socionext: account for napi_gro_receive never returning GRO_DROP



The napi_gro_receive function no longer returns GRO_DROP ever, making
handling GRO_DROP dead code. This commit removes that dead code.
Further, it's not even clear that device drivers have any business in
taking action after passing off received packets; that's arguably out of
their hands.

Fixes: 6570bc79 ("net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent df08126e

drivers/net/ethernet/socionext/netsec.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1044,8 +1044,9 @@ static int netsec_process_rx(struct netsec_priv *priv, int budget)
		skb->ip_summed = CHECKSUM_UNNECESSARY;

		next:
		if ((skb && napi_gro_receive(&priv->napi, skb) != GRO_DROP) \|\|
		xdp_result) {
		if (skb)
		napi_gro_receive(&priv->napi, skb);
		if (skb \|\| xdp_result) {
		ndev->stats.rx_packets++;
		ndev->stats.rx_bytes += xdp.data_end - xdp.data;
		}

Admin message