Commit e5dfe6b5 authored by Parav Pandit's avatar Parav Pandit Committed by Saeed Mahameed
Browse files

net/mlx5: Avoid exposing driver internal command helpers 



mlx5 command init and cleanup routines are internal to mlx5_core driver.
Hence, avoid exporting them and move their definition to mlx5_core
driver's internal file mlx5_core.h

Signed-off-by: default avatarParav Pandit <parav@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 59d2ae1d

drivers/net/ethernet/mellanox/mlx5/core/cmd.c

+0 −3
Original line number Diff line number Diff line
@@ -2142,7 +2142,6 @@ dma_pool_err: 
	kvfree(cmd->stats);

	return err;

}

EXPORT_SYMBOL(mlx5_cmd_init);



void mlx5_cmd_cleanup(struct mlx5_core_dev *dev)

{
@@ -2155,11 +2154,9 @@ void mlx5_cmd_cleanup(struct mlx5_core_dev *dev) 
	dma_pool_destroy(cmd->pool);

	kvfree(cmd->stats);

}

EXPORT_SYMBOL(mlx5_cmd_cleanup);



void mlx5_cmd_set_state(struct mlx5_core_dev *dev,

			enum mlx5_cmdif_state cmdif_state)

{

	dev->cmd.state = cmdif_state;

}
 
EXPORT_SYMBOL(mlx5_cmd_set_state);

drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h

+4 −0
Original line number Diff line number Diff line
@@ -122,6 +122,10 @@ enum mlx5_semaphore_space_address { 


int mlx5_query_hca_caps(struct mlx5_core_dev *dev);

int mlx5_query_board_id(struct mlx5_core_dev *dev);

int mlx5_cmd_init(struct mlx5_core_dev *dev);

void mlx5_cmd_cleanup(struct mlx5_core_dev *dev);

void mlx5_cmd_set_state(struct mlx5_core_dev *dev,

			enum mlx5_cmdif_state cmdif_state);

int mlx5_cmd_init_hca(struct mlx5_core_dev *dev, uint32_t *sw_owner_id);

int mlx5_cmd_teardown_hca(struct mlx5_core_dev *dev);

int mlx5_cmd_force_teardown_hca(struct mlx5_core_dev *dev);

include/linux/mlx5/driver.h

+0 −4
Original line number Diff line number Diff line
@@ -888,10 +888,6 @@ enum { 
	CMD_ALLOWED_OPCODE_ALL,

};



int mlx5_cmd_init(struct mlx5_core_dev *dev);

void mlx5_cmd_cleanup(struct mlx5_core_dev *dev);

void mlx5_cmd_set_state(struct mlx5_core_dev *dev,

			enum mlx5_cmdif_state cmdif_state);

void mlx5_cmd_use_events(struct mlx5_core_dev *dev);

void mlx5_cmd_use_polling(struct mlx5_core_dev *dev);

void mlx5_cmd_allowed_opcode(struct mlx5_core_dev *dev, u16 opcode);

CRA Git | Maintained and supported by SUSTech CRA and CCSE