gpio-mpc8xxx: add mpc8xxx_gpio_set_multiple function (e5db3b33) · Commits · 戴 / test

Add a set_multiple function to the MPC8xxx GPIO chip driver and thereby allow for actual performance improvements when setting multiple outputs simultaneously. In my case the time needed to configure an FPGA goes down from 48 s to 20 s. Change log: v6: - rebase on current linux-gpio devel branch v5: - no change v4: - change interface of the set_multiple driver function to use unsigned long as type for the bit fields - use generic bitops (which also use unsigned long for bit fields) v3: - change commit message v2: - add this patch (v1 included only changes to gpiolib) Signed-off-by:

Rojhalat Ibrahim <imr@rtschenk.de> Reviewed-by:

Alexandre Courbot <acourbot@nvidia.com> Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/gpio/gpio-mpc8xxx.c

+27 −0

Original line number	Diff line number	Diff line
		@@ -105,6 +105,32 @@ static void mpc8xxx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
		spin_unlock_irqrestore(&mpc8xxx_gc->lock, flags);
		}

		static void mpc8xxx_gpio_set_multiple(struct gpio_chip *gc,
		unsigned long mask, unsigned long bits)
		{
		struct of_mm_gpio_chip *mm = to_of_mm_gpio_chip(gc);
		struct mpc8xxx_gpio_chip *mpc8xxx_gc = to_mpc8xxx_gpio_chip(mm);
		unsigned long flags;
		int i;

		spin_lock_irqsave(&mpc8xxx_gc->lock, flags);

		for (i = 0; i < gc->ngpio; i++) {
		if (*mask == 0)
		break;
		if (__test_and_clear_bit(i, mask)) {
		if (test_bit(i, bits))
		mpc8xxx_gc->data \|= mpc8xxx_gpio2mask(i);
		else
		mpc8xxx_gc->data &= ~mpc8xxx_gpio2mask(i);
		}
		}

		out_be32(mm->regs + GPIO_DAT, mpc8xxx_gc->data);

		spin_unlock_irqrestore(&mpc8xxx_gc->lock, flags);
		}

		static int mpc8xxx_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio)
		{
		struct of_mm_gpio_chip *mm = to_of_mm_gpio_chip(gc);
		@@ -344,6 +370,7 @@ static void __init mpc8xxx_add_controller(struct device_node *np)
		gc->get = of_device_is_compatible(np, "fsl,mpc8572-gpio") ?
		mpc8572_gpio_get : mpc8xxx_gpio_get;
		gc->set = mpc8xxx_gpio_set;
		gc->set_multiple = mpc8xxx_gpio_set_multiple;
		gc->to_irq = mpc8xxx_gpio_to_irq;

		ret = of_mm_gpiochip_add(np, mm_gc);

Admin message