media: vicodec: Drop unused job_abort() (e5c413ed) · Commits · 戴 / test

The vicodec does not use the aborting field. In fact, this driver can't really cancel any work, since it performs all the work in device_run(). Signed-off-by:

Ezequiel Garcia <ezequiel@collabora.com> Signed-off-by:

Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:

Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

drivers/media/platform/vicodec/vicodec-core.c

+0 −11

Original line number	Diff line number	Diff line
		@@ -112,8 +112,6 @@ struct vicodec_ctx {

		struct v4l2_ctrl_handler hdl;

		/* Abort requested by m2m */
		int aborting;
		struct vb2_v4l2_buffer *last_src_buf;
		struct vb2_v4l2_buffer *last_dst_buf;

		@@ -378,14 +376,6 @@ restart:
		return 1;
		}

		static void job_abort(void *priv)
		{
		struct vicodec_ctx *ctx = priv;

		/* Will cancel the transaction in the next interrupt handler */
		ctx->aborting = 1;
		}

		/*
		* video ioctls
		*/
		@@ -1270,7 +1260,6 @@ static const struct video_device vicodec_videodev = {

		static const struct v4l2_m2m_ops m2m_ops = {
		.device_run = device_run,
		.job_abort = job_abort,
		.job_ready = job_ready,
		};

Admin message