Commit e5c399b0 authored May 27, 2020 by Ard Biesheuvel Committed by Rafael J. Wysocki May 27, 2020

ACPI: GED: use correct trigger type field in _Exx / _Lxx handling

Commit ea6f3af4 ("ACPI: GED: add support for _Exx / _Lxx handler
methods") added a reference to the 'triggering' field of either the
normal or the extended ACPI IRQ resource struct, but inadvertently used
the wrong pointer in the latter case. Note that both pointers refer to the
same union, and the 'triggering' field appears at the same offset in both
struct types, so it currently happens to work by accident. But let's fix
it nonetheless

Fixes: ea6f3af4 ("ACPI: GED: add support for _Exx / _Lxx handler methods")
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent ea6f3af4

drivers/acpi/evged.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -94,7 +94,7 @@ static acpi_status acpi_ged_request_interrupt(struct acpi_resource *ares,
		trigger = p->triggering;
		} else {
		gsi = pext->interrupts[0];
		trigger = p->triggering;
		trigger = pext->triggering;
		}

		irq = r.start;

Admin message