Commit e5bae867 authored Jul 30, 2015 by Boris BREZILLON Committed by Brian Norris Sep 30, 2015

mtd: mtdpart: fix add_mtd_partitions error path



If we fail to allocate a partition structure in the middle of the partition
creation process, the already allocated partitions are never removed, which
means they are still present in the partition list and their resources are
never freed.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: stable@vger.kernel.org
Signed-off-by: Brian Norris <computersforpeace@gmail.com>

parent d489ff42

drivers/mtd/mtdpart.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -664,8 +664,10 @@ int add_mtd_partitions(struct mtd_info *master,

		for (i = 0; i < nbparts; i++) {
		slave = allocate_partition(master, parts + i, i, cur_offset);
		if (IS_ERR(slave))
		if (IS_ERR(slave)) {
		del_mtd_partitions(master);
		return PTR_ERR(slave);
		}

		mutex_lock(&mtd_partitions_mutex);
		list_add(&slave->list, &mtd_partitions);

Admin message