Commit e5b5a61f authored Jul 31, 2015 by Ricardo Ribalda Delgado Committed by Jacek Anaszewski Aug 28, 2015

leds/led-class: Add missing put_device()



Devices found by class_find_device must be freed with put_device().
Otherwise the reference count will not work properly.

Fixes: a96aa64c ("leds/led-class: Handle LEDs with the same name")
Reported-by: Alan Tull <delicious.quinoa@gmail.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

parent 4fc5af86

drivers/leds/led-class.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -228,12 +228,15 @@ static int led_classdev_next_name(const char init_name, char name,
		{
		unsigned int i = 0;
		int ret = 0;
		struct device *dev;

		strlcpy(name, init_name, len);

		while (class_find_device(leds_class, NULL, name, match_name) &&
		(ret < len))
		while ((ret < len) &&
		(dev = class_find_device(leds_class, NULL, name, match_name))) {
		put_device(dev);
		ret = snprintf(name, len, "%s_%u", init_name, ++i);
		}

		if (ret >= len)
		return -ENOMEM;

Admin message