Commit e58650b5 authored Jul 27, 2018 by Jia-Ju Bai Committed by Dmitry Torokhov Jul 27, 2018

Input: wdt87xx_i2c - replace mdelay() with msleep() in wdt87xx_resume()



wdt87xx_resume() is never called in atomic context.  It calls mdelay() to
busily wait, which is not necessary.  mdelay() can be replaced with
msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 6c6212aa

drivers/input/touchscreen/wdt87xx_i2c.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1142,7 +1142,7 @@ static int __maybe_unused wdt87xx_resume(struct device *dev)
	* The chip may have been reset while system is resuming,		* The chip may have been reset while system is resuming,
	* give it some time to settle.		* give it some time to settle.
	*/		*/
	mdelay(100);		msleep(100);

	error = wdt87xx_send_command(client, VND_CMD_START, 0);		error = wdt87xx_send_command(client, VND_CMD_START, 0);
	if (error)		if (error)

Admin message