Unverified Commit e582f483 authored Feb 28, 2020 by Keyon Jie Committed by Mark Brown Mar 02, 2020

ASoC: SOF: pcm: skip DMA buffer pre-allocation

As discussion in ALSA https://patchwork.kernel.org/patch/11336023/

, it
is suggested to skip DMA buffer pre-allocation with passing size=0 when
calling snd_pcm_set_managed_buffer(), to make the full buffer_bytes
range configured in topology file selectable from user space, here do
the corresponding change in SOF PCM driver to implement it.

This change doesn't have dependency to the change that Takashi will do
in the ALSA core by adding total_pcm_alloc_bytes limitation to the
struct snd_card, it passes tests both with or without Takashi's coming
change on SOF CML platform.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Link: https://lore.kernel.org/r/20200228231850.9226-2-pierre-louis.bossart@linux.intel.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent a57ec83a

sound/soc/sof/pcm.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -601,8 +601,7 @@ static int sof_pcm_new(struct snd_soc_component *component,

		snd_pcm_set_managed_buffer(pcm->streams[stream].substream,
		SNDRV_DMA_TYPE_DEV_SG, sdev->dev,
		le32_to_cpu(caps->buffer_size_min),
		le32_to_cpu(caps->buffer_size_max));
		0, le32_to_cpu(caps->buffer_size_max));
		capture:
		stream = SNDRV_PCM_STREAM_CAPTURE;

		@@ -624,8 +623,7 @@ capture:

		snd_pcm_set_managed_buffer(pcm->streams[stream].substream,
		SNDRV_DMA_TYPE_DEV_SG, sdev->dev,
		le32_to_cpu(caps->buffer_size_min),
		le32_to_cpu(caps->buffer_size_max));
		0, le32_to_cpu(caps->buffer_size_max));

		return 0;
		}

Admin message