Commit e55f1a18 authored Aug 31, 2016 by NeilBrown Committed by Ilya Dryomov Oct 03, 2016

ceph: remove warning when ceph_releasepage() is called on dirty page



If O_DIRECT writes are racing with buffered writes, then
the call to invalidate_inode_pages2_range() can call ceph_releasepage()
on dirty pages.

Most filesystems hold inode_lock() across O_DIRECT writes so they do not
suffer this race, but cephfs deliberately drops the lock, and opens a window
for the race.

This race can be triggered with the generic/036 test from the xfstests
test suite.  It doesn't happen every time, but it does happen often.

As the possibilty is expected, remove the warning, and instead include
the PageDirty() status in the debug message.

Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Yan, Zheng <zyan@redhat.com>

parent 5d7eb1a3

fs/ceph/addr.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -175,9 +175,8 @@ static void ceph_invalidatepage(struct page *page, unsigned int offset,

		static int ceph_releasepage(struct page *page, gfp_t g)
		{
		dout("%p releasepage %p idx %lu\n", page->mapping->host,
		page, page->index);
		WARN_ON(PageDirty(page));
		dout("%p releasepage %p idx %lu (%sdirty)\n", page->mapping->host,
		page, page->index, PageDirty(page) ? "" : "not ");

		/* Can we release the page from the cache? */
		if (!ceph_release_fscache_page(page, g))

Admin message