Commit e55dddfe authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'dsa-fix-MV88E6131-tagging' 



Andrew Lunn says:

====================
Fix MV88E6131 tagging

Marvell has two different tagging protocols for frames passed to a
swicth. There is the older DSA and the newer EDSA. Somewhere along the
way, we broke support for switches which only support DSA, by trying
to configure them to use EDSA. These patches add back support for
switches which only support DSA, by allowing the drivers to
dynamically indicate the tagging protocol they support to the DSA
core. This needs to be dynamic since the mv88e6xxx has to support two
protocols.

Thanks go to Jamie Lentin for reporting the problem, helping debug it,
providing some of the fix, and testing.
====================

Tested-By: default avatarJamie Lentin <jm@lentin.co.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 1ae292a2 f027e0cc

drivers/net/dsa/b53/b53_common.c

+6 −1
Original line number Diff line number Diff line
@@ -1373,8 +1373,13 @@ static void b53_br_set_stp_state(struct dsa_switch *ds, int port, 
	b53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), reg);

}



static enum dsa_tag_protocol b53_get_tag_protocol(struct dsa_switch *ds)

{

	return DSA_TAG_PROTO_NONE;

}



static struct dsa_switch_driver b53_switch_ops = {

	.tag_protocol		= DSA_TAG_PROTO_NONE,

	.get_tag_protocol	= b53_get_tag_protocol,

	.setup			= b53_setup,

	.set_addr		= b53_set_addr,

	.get_strings		= b53_get_strings,

drivers/net/dsa/bcm_sf2.c

+6 −1
Original line number Diff line number Diff line
@@ -136,6 +136,11 @@ static int bcm_sf2_sw_get_sset_count(struct dsa_switch *ds) 
	return BCM_SF2_STATS_SIZE;

}



static enum dsa_tag_protocol bcm_sf2_sw_get_tag_protocol(struct dsa_switch *ds)

{

	return DSA_TAG_PROTO_BRCM;

}



static void bcm_sf2_imp_vlan_setup(struct dsa_switch *ds, int cpu_port)

{

	struct bcm_sf2_priv *priv = ds_to_priv(ds);
@@ -1577,8 +1582,8 @@ static int bcm_sf2_sw_setup(struct dsa_switch *ds) 
}



static struct dsa_switch_driver bcm_sf2_switch_driver = {

	.tag_protocol		= DSA_TAG_PROTO_BRCM,

	.setup			= bcm_sf2_sw_setup,

	.get_tag_protocol	= bcm_sf2_sw_get_tag_protocol,

	.set_addr		= bcm_sf2_sw_set_addr,

	.get_phy_flags		= bcm_sf2_sw_get_phy_flags,

	.get_strings		= bcm_sf2_sw_get_strings,

drivers/net/dsa/mv88e6060.c

+6 −1
Original line number Diff line number Diff line
@@ -69,6 +69,11 @@ static const char *mv88e6060_get_name(struct mii_bus *bus, int sw_addr) 
	return NULL;

}



static enum dsa_tag_protocol mv88e6060_get_tag_protocol(struct dsa_switch *ds)

{

	return DSA_TAG_PROTO_TRAILER;

}



static const char *mv88e6060_drv_probe(struct device *dsa_dev,

				       struct device *host_dev, int sw_addr,

				       void **_priv)
@@ -248,7 +253,7 @@ mv88e6060_phy_write(struct dsa_switch *ds, int port, int regnum, u16 val) 
}



static struct dsa_switch_driver mv88e6060_switch_driver = {

	.tag_protocol	= DSA_TAG_PROTO_TRAILER,

	.get_tag_protocol = mv88e6060_get_tag_protocol,

	.probe		= mv88e6060_drv_probe,

	.setup		= mv88e6060_setup,

	.set_addr	= mv88e6060_set_addr,

drivers/net/dsa/mv88e6xxx/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ config NET_DSA_MV88E6XXX 
	tristate "Marvell 88E6xxx Ethernet switch fabric support"

	depends on NET_DSA

	select NET_DSA_TAG_EDSA

	select NET_DSA_TAG_DSA

	help

	  This driver adds support for most of the Marvell 88E6xxx models of

	  Ethernet switch chips, except 88E6060.

drivers/net/dsa/mv88e6xxx/chip.c

+36 −25
Original line number Diff line number Diff line
@@ -486,6 +486,11 @@ static void mv88e6xxx_ppu_state_init(struct mv88e6xxx_chip *chip) 
	chip->ppu_timer.function = mv88e6xxx_ppu_reenable_timer;

}



static void mv88e6xxx_ppu_state_destroy(struct mv88e6xxx_chip *chip)

{

	del_timer_sync(&chip->ppu_timer);

}



static int mv88e6xxx_phy_ppu_read(struct mv88e6xxx_chip *chip, int addr,

				  int reg, u16 *val)

{
@@ -2483,28 +2488,13 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port) 
		PORT_CONTROL_USE_TAG | PORT_CONTROL_USE_IP |

		PORT_CONTROL_STATE_FORWARDING;

	if (dsa_is_cpu_port(ds, port)) {

		if (mv88e6xxx_6095_family(chip) || mv88e6xxx_6185_family(chip))

			reg |= PORT_CONTROL_DSA_TAG;

		if (mv88e6xxx_6352_family(chip) ||

		    mv88e6xxx_6351_family(chip) ||

		    mv88e6xxx_6165_family(chip) ||

		    mv88e6xxx_6097_family(chip) ||

		    mv88e6xxx_6320_family(chip)) {

		if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_EDSA))

			reg |= PORT_CONTROL_FRAME_ETHER_TYPE_DSA |

				PORT_CONTROL_FORWARD_UNKNOWN |

				PORT_CONTROL_FORWARD_UNKNOWN_MC;

		}



		if (mv88e6xxx_6352_family(chip) ||

		    mv88e6xxx_6351_family(chip) ||

		    mv88e6xxx_6165_family(chip) ||

		    mv88e6xxx_6097_family(chip) ||

		    mv88e6xxx_6095_family(chip) ||

		    mv88e6xxx_6065_family(chip) ||

		    mv88e6xxx_6185_family(chip) ||

		    mv88e6xxx_6320_family(chip)) {

			reg |= PORT_CONTROL_EGRESS_ADD_TAG;

		}

		else

			reg |= PORT_CONTROL_DSA_TAG;

		reg |= PORT_CONTROL_EGRESS_ADD_TAG |

			PORT_CONTROL_FORWARD_UNKNOWN;

	}

	if (dsa_is_dsa_port(ds, port)) {

		if (mv88e6xxx_6095_family(chip) ||
@@ -2632,10 +2622,13 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port) 
		/* Port Ethertype: use the Ethertype DSA Ethertype

		 * value.

		 */

		if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_EDSA)) {

			ret = _mv88e6xxx_reg_write(chip, REG_PORT(port),

						   PORT_ETH_TYPE, ETH_P_EDSA);

			if (ret)

				return ret;

		}



		/* Tag Remap: use an identity 802.1p prio -> switch

		 * prio mapping.

		 */
@@ -3904,6 +3897,13 @@ static void mv88e6xxx_phy_init(struct mv88e6xxx_chip *chip) 
	}

}



static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip)

{

	if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_PPU)) {

		mv88e6xxx_ppu_state_destroy(chip);

	}

}



static int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip,

			      struct mii_bus *bus, int sw_addr)

{
@@ -3924,6 +3924,16 @@ static int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip, 
	return 0;

}



static enum dsa_tag_protocol mv88e6xxx_get_tag_protocol(struct dsa_switch *ds)

{

	struct mv88e6xxx_chip *chip = ds_to_priv(ds);



	if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_EDSA))

		return DSA_TAG_PROTO_EDSA;



	return DSA_TAG_PROTO_DSA;

}



static const char *mv88e6xxx_drv_probe(struct device *dsa_dev,

				       struct device *host_dev, int sw_addr,

				       void **priv)
@@ -3967,8 +3977,8 @@ free: 
}



static struct dsa_switch_driver mv88e6xxx_switch_driver = {

	.tag_protocol		= DSA_TAG_PROTO_EDSA,

	.probe			= mv88e6xxx_drv_probe,

	.get_tag_protocol	= mv88e6xxx_get_tag_protocol,

	.setup			= mv88e6xxx_setup,

	.set_addr		= mv88e6xxx_set_addr,

	.adjust_link		= mv88e6xxx_adjust_link,
@@ -4082,6 +4092,7 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev) 
	struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);

	struct mv88e6xxx_chip *chip = ds_to_priv(ds);



	mv88e6xxx_phy_destroy(chip);

	mv88e6xxx_unregister_switch(chip);

	mv88e6xxx_mdio_unregister(chip);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE