Commit e558b018 authored Aug 16, 2013 by Vlad Yasevich Committed by David S. Miller Aug 20, 2013

macvtap: Correctly set tap features when IFF_VNET_HDR is disabled.



When the user turns off IFF_VNET_HDR flag, attempts to change
offload features via TUNSETOFFLOAD do not work.  This could cause
GSO packets to be delivered to the user when the user is
not prepared to handle them.

To solve, allow processing of TUNSETOFFLOAD when IFF_VNET_HDR is
disabled.

Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a567dd62

drivers/net/macvtap.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1163,10 +1163,6 @@ static long macvtap_ioctl(struct file *file, unsigned int cmd,
		TUN_F_TSO_ECN \| TUN_F_UFO))
		return -EINVAL;

		/* TODO: only accept frames with the features that
		got enabled for forwarded frames */
		if (!(q->flags & IFF_VNET_HDR))
		return -EINVAL;
		rtnl_lock();
		ret = set_offload(q, arg);
		rtnl_unlock();

Admin message