Commit e5548b05 authored Nov 23, 2020 by Zhang Qilong Committed by Greg Kroah-Hartman Dec 09, 2020

usb: oxu210hp-hcd: Fix memory leak in oxu_create



usb_create_hcd will alloc memory for hcd, and we should
call usb_put_hcd to free it when adding fails to prevent
memory leak.

Fixes: b92a78e5 ("usb host: Oxford OXU210HP HCD driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201123145809.1456541-1-zhangqilong3@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3b78ef0d

drivers/usb/host/oxu210hp-hcd.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -4152,8 +4152,10 @@ static struct usb_hcd oxu_create(struct platform_device pdev,
		oxu->is_otg = otg;

		ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
		if (ret < 0)
		if (ret < 0) {
		usb_put_hcd(hcd);
		return ERR_PTR(ret);
		}

		device_wakeup_enable(hcd->self.controller);
		return hcd;

Admin message