Commit e5420877 authored Nov 28, 2018 by Pan Bian Committed by Richard Weinberger Dec 13, 2018

ubi: Do not drop UBI device reference before using



The UBI device reference is dropped but then the device is used as a
parameter of ubi_err. The bug is introduced in changing ubi_err's
behavior. The old ubi_err does not require a UBI device as its first
parameter, but the new one does.

Fixes: 32608703 ("UBI: Extend UBI layer debug/messaging capabilities")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent b95f83ab

drivers/mtd/ubi/kapi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -227,9 +227,9 @@ out_unlock:
		out_free:
		kfree(desc);
		out_put_ubi:
		ubi_put_device(ubi);
		ubi_err(ubi, "cannot open device %d, volume %d, error %d",
		ubi_num, vol_id, err);
		ubi_put_device(ubi);
		return ERR_PTR(err);
		}
		EXPORT_SYMBOL_GPL(ubi_open_volume);

Admin message