Commit e5304db8 authored Sep 13, 2013 by Graeme Smecher Committed by Linus Walleij Sep 23, 2013

gpio: pca953x: Don't flip bits on PCA957x GPIO expanders when probing them.



The pca957x driver supports a handful of I2C GPIO expanders from NXP, Maxim,
and TI. For the PCA9574 and PCA9575 devices only, the driver resets the GPIO
level and direction in the pca957x_probe function. This seems like the wrong
thing to do, since it can cause hardware bit twiddles during warm reboots when
the chip state and reset values don't match.

This kind of initialization is best left upstream (in a bootloader) or
downstream (in userspace). It's also an inconsistency across devices supported
by this driver.

This patch is NOT boot-tested: the SoC I'm  using is stuck on 2.6.37, and the
patch doesn't apply trivially.

Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 8fa82b16

drivers/gpio/gpio-pca953x.c

+0 −11

Original line number	Diff line number	Diff line
		@@ -683,17 +683,6 @@ static int device_pca957x_init(struct pca953x_chip *chip, u32 invert)
		int ret;
		u8 val[MAX_BANK];

		/* Let every port in proper state, that could save power */
		memset(val, 0, NBANK(chip));
		pca953x_write_regs(chip, PCA957X_PUPD, val);
		memset(val, 0xFF, NBANK(chip));
		pca953x_write_regs(chip, PCA957X_CFG, val);
		memset(val, 0, NBANK(chip));
		pca953x_write_regs(chip, PCA957X_OUT, val);

		ret = pca953x_read_regs(chip, PCA957X_IN, val);
		if (ret)
		goto out;
		ret = pca953x_read_regs(chip, PCA957X_OUT, chip->reg_output);
		if (ret)
		goto out;

Admin message