Commit e52bbd5c authored by Finn Thain's avatar Finn Thain Committed by Martin K. Petersen
Browse files

ncr5380: Cleanup bogus {request,release}_region() calls 



Commit 8b801ead ("[ARM] rpc: update Acorn SCSI drivers to modern ecard
interfaces") neglected to remove a request_region() call in cumana_1.c.

Commit eda32612f7b2 ("[PATCH] give all LLDD driver a ->release method") in
history/history.git added some pointless release_region() calls in dtc.c,
pas16.c and t128.c.

Fix these issues.

Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4d029e9a

drivers/scsi/arm/cumana_1.c

+0 −6
Original line number Diff line number Diff line
@@ -245,12 +245,6 @@ static int cumanascsi1_probe(struct expansion_card *ec, 
        priv(host)->ctrl = 0;

        writeb(0, priv(host)->base + CTRL);



	host->n_io_port = 255;

	if (!(request_region(host->io_port, host->n_io_port, "CumanaSCSI-1"))) {

		ret = -EBUSY;

		goto out_unmap;

	}



	ret = request_irq(host->irq, cumanascsi_intr, 0,

			  "CumanaSCSI-1", host);

	if (ret) {

drivers/scsi/dtc.c

+0 −2
Original line number Diff line number Diff line
@@ -423,8 +423,6 @@ static int dtc_release(struct Scsi_Host *shost) 
	if (shost->irq != NO_IRQ)

		free_irq(shost->irq, shost);

	NCR5380_exit(shost);

	if (shost->io_port && shost->n_io_port)

		release_region(shost->io_port, shost->n_io_port);

	scsi_unregister(shost);

	iounmap(hostdata->base);

	return 0;

drivers/scsi/pas16.c

+0 −2
Original line number Diff line number Diff line
@@ -540,8 +540,6 @@ static int pas16_release(struct Scsi_Host *shost) 
	if (shost->irq != NO_IRQ)

		free_irq(shost->irq, shost);

	NCR5380_exit(shost);

	if (shost->io_port && shost->n_io_port)

		release_region(shost->io_port, shost->n_io_port);

	scsi_unregister(shost);

	return 0;

}

drivers/scsi/t128.c

+0 −2
Original line number Diff line number Diff line
@@ -255,8 +255,6 @@ static int t128_release(struct Scsi_Host *shost) 
	if (shost->irq != NO_IRQ)

		free_irq(shost->irq, shost);

	NCR5380_exit(shost);

	if (shost->io_port && shost->n_io_port)

		release_region(shost->io_port, shost->n_io_port);

	scsi_unregister(shost);

	iounmap(hostdata->base);

	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE