Commit e5285860 authored by Jayamohan Kallickal's avatar Jayamohan Kallickal Committed by James Bottomley
Browse files

[SCSI] be2iscsi: Fix for kdump failure 



This patch fixes the Kdump failure reported by Redhat wich was caused by
be2iscsi resetting the Chip when be2iscsi detects it is in crashdump mode. If
be2net was loaded before be2iscsi then this leaves be2net driver hanging on to
resources that the chip stopped recognising after the reset.

This patch replaces  chip reset with Function reset so that only the
particular function and not the whole chip is affected

Signed-off-by: default avatarJayamohan Kallickal <jayamohan.kallickal@emulex.com>
Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 528c04ee

drivers/scsi/be2iscsi/be_cmds.c

+19 −0
Original line number Diff line number Diff line
@@ -868,3 +868,22 @@ error: 
		beiscsi_cmd_q_destroy(ctrl, NULL, QTYPE_SGL);

	return status;

}



int beiscsi_cmd_reset_function(struct beiscsi_hba  *phba)

{

	struct be_ctrl_info *ctrl = &phba->ctrl;

	struct be_mcc_wrb *wrb = wrb_from_mbox(&ctrl->mbox_mem);

	struct be_post_sgl_pages_req *req = embedded_payload(wrb);

	int status;



	spin_lock(&ctrl->mbox_lock);



	req = embedded_payload(wrb);

	be_wrb_hdr_prepare(wrb, sizeof(*req), true, 0);

	be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_COMMON,

			   OPCODE_COMMON_FUNCTION_RESET, sizeof(*req));

	status = be_mbox_notify_wait(phba);



	spin_unlock(&ctrl->mbox_lock);

	return status;

}

drivers/scsi/be2iscsi/be_cmds.h

+2 −0
Original line number Diff line number Diff line
@@ -561,6 +561,8 @@ int be_cmd_iscsi_post_sgl_pages(struct be_ctrl_info *ctrl, 
				struct be_dma_mem *q_mem, u32 page_offset,

				u32 num_pages);



int beiscsi_cmd_reset_function(struct beiscsi_hba *phba);



int be_cmd_wrbq_create(struct be_ctrl_info *ctrl, struct be_dma_mem *q_mem,

		       struct be_queue_info *wrbq);

drivers/scsi/be2iscsi/be_main.c

+1 −1
Original line number Diff line number Diff line
@@ -4276,7 +4276,7 @@ static int __devinit beiscsi_dev_probe(struct pci_dev *pcidev, 
			gcrashmode++;

			shost_printk(KERN_ERR, phba->shost,

				"Loading Driver in crashdump mode\n");

			ret = beiscsi_pci_soft_reset(phba);

			ret = beiscsi_cmd_reset_function(phba);

			if (ret) {

				shost_printk(KERN_ERR, phba->shost,

					"Reset Failed. Aborting Crashdump\n");

CRA Git | Maintained and supported by SUSTech CRA and CCSE