Commit e51d68e7 authored Dec 09, 2020 by Anant Thazhemadam Committed by Jan Kara Dec 09, 2020

fs: quota: fix array-index-out-of-bounds bug by passing correct argument to...

fs: quota: fix array-index-out-of-bounds bug by passing correct argument to vfs_cleanup_quota_inode()

When dquot_resume() was last updated, the argument that got passed
to vfs_cleanup_quota_inode was incorrectly set.

If type = -1 and dquot_load_quota_sb() returns a negative value,
then vfs_cleanup_quota_inode() gets called with -1 passed as an
argument, and this leads to an array-index-out-of-bounds bug.

Fix this issue by correctly passing the arguments.

Fixes: ae45f07d ("quota: Simplify dquot_resume()")
Link: https://lore.kernel.org/r/20201208194338.7064-1-anant.thazhemadam@gmail.com


Reported-by:  <syzbot+2643e825238d7aabb37f@syzkaller.appspotmail.com>
Tested-by:  <syzbot+2643e825238d7aabb37f@syzkaller.appspotmail.com>
CC: stable@vger.kernel.org
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>

parent d24396c5

fs/quota/dquot.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2455,7 +2455,7 @@ int dquot_resume(struct super_block *sb, int type)
		ret = dquot_load_quota_sb(sb, cnt, dqopt->info[cnt].dqi_fmt_id,
		flags);
		if (ret < 0)
		vfs_cleanup_quota_inode(sb, type);
		vfs_cleanup_quota_inode(sb, cnt);
		}

		return ret;

Admin message