Commit e514cc0a authored Jul 15, 2016 by Dan Carpenter Committed by Herbert Xu Jul 19, 2016

crypto: nx - off by one bug in nx_of_update_msc()



The props->ap[] array is defined like this:

	struct alg_props ap[NX_MAX_FC][NX_MAX_MODE][3];

So we can see that if msc->fc and msc->mode are == to NX_MAX_FC or
NX_MAX_MODE then we're off by one.

Fixes: ae0222b7 ('powerpc/crypto: nx driver code supporting nx encryption')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent a6d7bfd0

drivers/crypto/nx/nx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -392,7 +392,7 @@ static void nx_of_update_msc(struct device *dev,
		((bytes_so_far + sizeof(struct msc_triplet)) <= lenp) &&
		i < msc->triplets;
		i++) {
		if (msc->fc > NX_MAX_FC \|\| msc->mode > NX_MAX_MODE) {
		if (msc->fc >= NX_MAX_FC \|\| msc->mode >= NX_MAX_MODE) {
		dev_err(dev, "unknown function code/mode "
		"combo: %d/%d (ignored)\n", msc->fc,
		msc->mode);

Admin message