Commit e50838c2 authored Feb 15, 2019 by Kaike Wan Committed by Jason Gunthorpe Feb 15, 2019

IB/hfi1: Fix a build warning for TID RDMA READ



The following build warning was produced for the TID RDMA READ
patch ("IB/hfi1: Enable TID RDMA READ protocol"):

drivers/infiniband/hw/hfi1/qp.c: In function 'hfi1_setup_wqe':
drivers/infiniband/hw/hfi1/qp.c:328:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   hfi1_setup_tid_rdma_wqe(qp, wqe);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/hw/hfi1/qp.c:329:2: note: here
  case IB_QPT_UC:
  ^~~~

This patch will fix the issue by adding the "fall through" comment.

Fixes: f1ab4efa ("IB/hfi1: Enable TID RDMA READ protocol")
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 9a778678

drivers/infiniband/hw/hfi1/qp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -326,6 +326,7 @@ int hfi1_setup_wqe(struct rvt_qp qp, struct rvt_swqe wqe, bool *call_send)
		switch (qp->ibqp.qp_type) {
		case IB_QPT_RC:
		hfi1_setup_tid_rdma_wqe(qp, wqe);
		/* fall through */
		case IB_QPT_UC:
		if (wqe->length > 0x80000000U)
		return -EINVAL;

Admin message