Commit e4f29206 authored Nov 26, 2013 by Steven Whitehouse

GFS2: Clean up releasepage

For historical reasons, we drop and retake the log lock in ->releasepage()
however, since there is no reason why we cannot hold the log lock over
the whole function, this allows some simplification. In particular,
pinning a buffer is only ever done under the log lock, so it is possible
here to remove the test for pinned buffers in the second loop, since it
is impossible for that to happen (it is also tested in the first loop).

As a result, two tests made later in the second loop become constants
and can also be reduced to the only possible branch. So the net result
is to remove various bits of unreachable code and make this more
readable.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent 5ea5050c

fs/gfs2/aops.c

+5 −13

Original line number	Diff line number	Diff line
		@@ -1080,30 +1080,22 @@ int gfs2_releasepage(struct page *page, gfp_t gfp_mask)
		bh = bh->b_this_page;
		} while(bh != head);
		spin_unlock(&sdp->sd_ail_lock);
		gfs2_log_unlock(sdp);

		head = bh = page_buffers(page);
		do {
		gfs2_log_lock(sdp);
		bd = bh->b_private;
		if (bd) {
		gfs2_assert_warn(sdp, bd->bd_bh == bh);
		if (!list_empty(&bd->bd_list)) {
		if (!buffer_pinned(bh))
		if (!list_empty(&bd->bd_list))
		list_del_init(&bd->bd_list);
		else
		bd = NULL;
		}
		if (bd)
		bd->bd_bh = NULL;
		bh->b_private = NULL;
		}
		gfs2_log_unlock(sdp);
		if (bd)
		kmem_cache_free(gfs2_bufdata_cachep, bd);
		}

		bh = bh->b_this_page;
		} while (bh != head);
		gfs2_log_unlock(sdp);

		return try_to_free_buffers(page);

Admin message