Commit e4ec48d3 authored Apr 07, 2019 by Trond Myklebust Committed by Anna Schumaker Apr 25, 2019

SUNRPC: Make "no retrans timeout" soft tasks behave like softconn for timeouts

If a soft NFSv4 request is sent, then we don't need it to time out unless
the connection breaks. The reason is that as long as the connection is
unbroken, the protocol states that the server is not allowed to drop the
request. IOW: as long as the connection remains unbroken, the client may
assume that all transmitted RPC requests are being processed by the server,
and that retransmissions and timeouts of those requests are unwarranted.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent 5ad64b36

net/sunrpc/clnt.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -2318,6 +2318,15 @@ rpc_check_timeout(struct rpc_task *task)
		}

		if (RPC_IS_SOFT(task)) {
		/*
		* Once a "no retrans timeout" soft tasks (a.k.a NFSv4) has
		* been sent, it should time out only if the transport
		* connection gets terminally broken.
		*/
		if ((task->tk_flags & RPC_TASK_NO_RETRANS_TIMEOUT) &&
		rpc_check_connected(task->tk_rqstp))
		return;

		if (clnt->cl_chatty) {
		printk(KERN_NOTICE "%s: server %s not responding, timed out\n",
		clnt->cl_program->name,

Admin message