Commit e4e721fe authored by Tiezhu Yang's avatar Tiezhu Yang Committed by Richard Weinberger
Browse files

um: vector: Use GFP_ATOMIC under spin lock 



Use GFP_ATOMIC instead of GFP_KERNEL under spin lock to fix possible
sleep-in-atomic-context bugs.

Fixes: 9807019a ("um: Loadable BPF "Firmware" for vector drivers")
Signed-off-by: default avatarTiezhu Yang <yangtiezhu@loongson.cn>
Acked-By: default avatarAnton Ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent bab991cf

arch/um/drivers/vector_kern.c

+2 −2
Original line number Diff line number Diff line
@@ -1403,7 +1403,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev, 
		kfree(vp->bpf->filter);

		vp->bpf->filter = NULL;

	} else {

		vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_KERNEL);

		vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_ATOMIC);

		if (vp->bpf == NULL) {

			netdev_err(dev, "failed to allocate memory for firmware\n");

			goto flash_fail;
@@ -1415,7 +1415,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev, 
	if (request_firmware(&fw, efl->data, &vdevice->pdev.dev))

		goto flash_fail;



	vp->bpf->filter = kmemdup(fw->data, fw->size, GFP_KERNEL);

	vp->bpf->filter = kmemdup(fw->data, fw->size, GFP_ATOMIC);

	if (!vp->bpf->filter)

		goto free_buffer;

CRA Git | Maintained and supported by SUSTech CRA and CCSE